Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo run -p ci fails using stable rust #8962

Open
cart opened this issue Jun 26, 2023 · 4 comments
Open

cargo run -p ci fails using stable rust #8962

cart opened this issue Jun 26, 2023 · 4 comments
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior

Comments

@cart
Copy link
Member

cart commented Jun 26, 2023

Bevy version

8fa94a0

What went wrong

The "missing_deref compile fail test" is currently failing on my machine (linux, stable rust 1.70) due to a mismatched error message. CI is not currently failing because it is using nightly (and the expected error was generated with nightly).

I think this is also what @robtfm is hitting in #5703.

I think we should operate under the assumption that Bevy devs are developing on a stable compiler. Compile fail tests should probably pass on stable Bevy / CI should probably also run these tests on stable.

@cart cart added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled A-Build-System Related to build systems or continuous integration and removed S-Needs-Triage This issue needs to be labelled labels Jun 26, 2023
@mockersf
Copy link
Member

mockersf commented Jun 26, 2023

CI is not using nightly for that step, it's on stable.

I can reproduce the failure on my Mac, but it's successful on a fresh ubuntu container with rust stable

@cart
Copy link
Member Author

cart commented Jun 26, 2023

Haha thats suboptimal. As an additional datapoint: this specific test passes on nightly for me (although other tests fail). Maybe we'll have fully synced up error messages in the next stable release?

@nakedible
Copy link
Contributor

Fails on debian bookworm.

@BD103
Copy link
Member

BD103 commented Jan 16, 2024

Additionally it now fails on MacOS as of Rust 1.75.0. (Originally from #11372.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

4 participants