Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding proc_macro #[required(TransformComponent, ...)] for Component. #14737

Closed
Jerrody opened this issue Aug 13, 2024 · 3 comments
Closed

Adding proc_macro #[required(TransformComponent, ...)] for Component. #14737

Jerrody opened this issue Aug 13, 2024 · 3 comments
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible X-Controversial There is active debate or serious implications around merging this PR

Comments

@Jerrody
Copy link

Jerrody commented Aug 13, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

A required proc_macro will add automatically specified components along with component that has this proc_macro.

What solution would you like?

Don't know.

What alternative(s) have you considered?

None.

Additional context

This is similiar to the Unity's RequieredComponent attribute. If we specify this attribute, then, with adding component to the GameObject, will be also added specified components (by components I mean MonoBehaviours).
@Jerrody Jerrody added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 13, 2024
@Jerrody Jerrody changed the title Adding proc_macro #required(TransformComponent, ...) for Component. Adding proc_macro #[required(TransformComponent, ...)] for Component. Aug 13, 2024
@MrGVSV
Copy link
Member

MrGVSV commented Aug 13, 2024

This is actually being discussed/designed over in #14437! 😄

@MrGVSV MrGVSV added A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels Aug 13, 2024
@alice-i-cecile alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label Aug 13, 2024
@Jerrody
Copy link
Author

Jerrody commented Aug 13, 2024

This is actually being discussed/designed over in #14437! 😄

Oh, thanks. Didn't see it.

@alice-i-cecile
Copy link
Member

Closing as a duplicate of #7272. Being added in #14791.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alice-i-cecile @MrGVSV @Jerrody