Fixed getBlocks method returning DocPad instead of blocks #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balupton
added a commit
that referenced
this pull request
Sep 1, 2013
Fixed getBlocks method returning DocPad instead of blocks
|
Great catches :) |
balupton
added a commit
that referenced
this pull request
Sep 7, 2013
- v6.52.0 September 8, 2013 - Pay more attention to getmac errors - Ensure completion callback (when specified) is always fired for the `DocPad::error` and `DocPad::track` methods - Fixed `DocPad::getBlocks` returning the DocPad instance instead of the blocks - Thanks to [Bruno Heridet](https://github.com/Delapouite) for [pull request #612](#612) - Added `DocPad::getIgnoreOpts` method to help clean up some code - Thanks to [Bruno Heridet](https://github.com/Delapouite) for [pull request #612](#611) - Removed all calls to `process.exit` by instead destroying DocPad properly causing an automatic shutdown if that is what is desired - Fatal errors are now written to stderr instead of stdout - Updated dependencies
|
Released to v6.52.0 |
balupton
added a commit
that referenced
this pull request
Oct 23, 2013
Fixed getBlocks method returning DocPad instead of blocks
balupton
added a commit
that referenced
this pull request
Oct 23, 2013
- v6.52.0 September 8, 2013 - Pay more attention to getmac errors - Ensure completion callback (when specified) is always fired for the `DocPad::error` and `DocPad::track` methods - Fixed `DocPad::getBlocks` returning the DocPad instance instead of the blocks - Thanks to [Bruno Heridet](https://github.com/Delapouite) for [pull request #612](#612) - Added `DocPad::getIgnoreOpts` method to help clean up some code - Thanks to [Bruno Heridet](https://github.com/Delapouite) for [pull request #612](#611) - Removed all calls to `process.exit` by instead destroying DocPad properly causing an automatic shutdown if that is what is desired - Fatal errors are now written to stderr instead of stdout - Updated dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Just a minor fix to on the blocks getter. Also made all the chaining consistent across the file.