From b0322cff8c6f892dbb72a87d1c141ed4b3b6f2e4 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Tue, 2 Aug 2022 13:52:44 -0700 Subject: [PATCH] fix noop toString() diagnostics (#35100) --- lib/web_ui/dev/create_simulator.dart | 2 +- lib/web_ui/dev/utils.dart | 2 +- lib/web_ui/test/text/line_breaker_test.dart | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/web_ui/dev/create_simulator.dart b/lib/web_ui/dev/create_simulator.dart index 85fd076c4d6ed..0ec86fd8f5455 100644 --- a/lib/web_ui/dev/create_simulator.dart +++ b/lib/web_ui/dev/create_simulator.dart @@ -27,7 +27,7 @@ class CreateSimulatorCommand extends Command with ArgUtils { lock.minorVersion, lock.device, ); - print('INFO: Simulator created ${simulator.toString()}'); + print('INFO: Simulator created $simulator'); } catch (e) { throw Exception('Error creating requested simulator. You can use Xcode ' 'to install more versions: XCode > Preferences > Components.' diff --git a/lib/web_ui/dev/utils.dart b/lib/web_ui/dev/utils.dart index 0986178e421dd..21c580e9c1ae5 100644 --- a/lib/web_ui/dev/utils.dart +++ b/lib/web_ui/dev/utils.dart @@ -276,7 +276,7 @@ Future runFlutter( if (exitCode != 0) { throw ToolExit( 'ERROR: Failed to run $executable with ' - 'arguments ${arguments.toString()}. Exited with exit code $exitCode', + 'arguments $arguments. Exited with exit code $exitCode', exitCode: exitCode, ); } diff --git a/lib/web_ui/test/text/line_breaker_test.dart b/lib/web_ui/test/text/line_breaker_test.dart index c5c6b6083875e..3b218552b829e 100644 --- a/lib/web_ui/test/text/line_breaker_test.dart +++ b/lib/web_ui/test/text/line_breaker_test.dart @@ -263,7 +263,7 @@ void testMain() { result.index, i, reason: 'Failed at test case number $t:\n' - '${testCase.toString()}\n' + '$testCase\n' '"$text"\n' '\nExpected line break at {$lastLineBreak - $i} but found line break at {$lastLineBreak - ${result.index}}.', ); @@ -283,7 +283,7 @@ void testMain() { result.index, greaterThan(i), reason: 'Failed at test case number $t:\n' - '${testCase.toString()}\n' + '$testCase\n' '"$text"\n' '\nUnexpected line break found at {$lastLineBreak - ${result.index}}.', );