From 5e943dc262ffbde626c59ea91980b67496268c58 Mon Sep 17 00:00:00 2001 From: Beto Dealmeida Date: Mon, 29 Apr 2024 17:16:48 -0400 Subject: [PATCH] fix: revert #317 --- pydruid/db/api.py | 2 +- tests/db/test_cursor.py | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/pydruid/db/api.py b/pydruid/db/api.py index d352a312..cfc97ea1 100644 --- a/pydruid/db/api.py +++ b/pydruid/db/api.py @@ -429,7 +429,7 @@ def rows_from_chunks(chunks): def apply_parameters(operation, parameters): if not parameters: - return operation % () + return operation escaped_parameters = {key: escape(value) for key, value in parameters.items()} return operation % escaped_parameters diff --git a/tests/db/test_cursor.py b/tests/db/test_cursor.py index 3dc25954..9287b403 100644 --- a/tests/db/test_cursor.py +++ b/tests/db/test_cursor.py @@ -121,11 +121,11 @@ def test_names_with_underscores(self, requests_post_mock): def test_apply_parameters(self): self.assertEqual( - apply_parameters('SELECT 100 AS "100%%"', None), 'SELECT 100 AS "100%"' + apply_parameters('SELECT 100 AS "100%"', None), 'SELECT 100 AS "100%"' ) self.assertEqual( - apply_parameters('SELECT 100 AS "100%%"', {}), 'SELECT 100 AS "100%"' + apply_parameters('SELECT 100 AS "100%"', {}), 'SELECT 100 AS "100%"' ) self.assertEqual( @@ -147,11 +147,6 @@ def test_apply_parameters(self): apply_parameters("SELECT %(key)s", {"key": False}), "SELECT FALSE" ) - self.assertEqual( - apply_parameters("SELECT * FROM t WHERE name LIKE '%%a'", None), - "SELECT * FROM t WHERE name LIKE '%a'", - ) - if __name__ == "__main__": unittest.main()