From 348fc1d8378a00c25839203ac45f8e2c2eac10ef Mon Sep 17 00:00:00 2001
From: Earlopain <14981592+Earlopain@users.noreply.github.com>
Date: Sun, 26 Jan 2025 16:57:50 +0100
Subject: [PATCH] Fix passing a block to `advisory_lock` in tests (#1587)

This method does not take a block. As such, the expectation is never executed
---
 spec/app/models/concerns/good_job/advisory_lockable_spec.rb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/spec/app/models/concerns/good_job/advisory_lockable_spec.rb b/spec/app/models/concerns/good_job/advisory_lockable_spec.rb
index c41565bc..d363a0ba 100644
--- a/spec/app/models/concerns/good_job/advisory_lockable_spec.rb
+++ b/spec/app/models/concerns/good_job/advisory_lockable_spec.rb
@@ -483,9 +483,8 @@
 
       it "locks and unlocks" do
         GoodJob::Job.transaction do
-          job.advisory_lock(function: "pg_advisory_xact_lock") do
-            expect(job.advisory_locked?).to be true
-          end
+          job.advisory_lock(function: "pg_advisory_xact_lock")
+          expect(job.advisory_locked?).to be true
         end
         expect(job.advisory_locked?).to be false
       end