Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup should not fail when temp file removed #18

Closed
wmertens opened this issue Nov 6, 2017 · 5 comments
Closed

cleanup should not fail when temp file removed #18

wmertens opened this issue Nov 6, 2017 · 5 comments

Comments

@wmertens
Copy link

wmertens commented Nov 6, 2017

I'm using .withFile() to guard a file download-and-move-into-place, but that fails after it completes because it wants to delete the temp file which is already gone.

In the regular node-tmp, I suppose I would not be calling cleanup after the move succeeds, but with withFile I don't have a choice.

I think .withFile() should catch and ignore ENOENT errors.

@benjamingr
Copy link
Owner

Thanks for the report, taking a look.

@benjamingr
Copy link
Owner

Hey, it looks like this issue has already been fixed in upstream node-tmp, I'll update the version in package.json and do a release raszi/node-tmp#115

@wmertens
Copy link
Author

wmertens commented Nov 6, 2017

Sweet! ⚡️ Super speedy too :)

@benjamingr
Copy link
Owner

I've published 1.0.4, let me know if the issue has been resolved on your end, thanks for the report.

@wmertens
Copy link
Author

wmertens commented Nov 6, 2017

It works nicely, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants