-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow float32 matrices to be used as input #17
Comments
Just found a solution, |
There is some code to specify if you want to generate 32 or 64 bit factors as the output of this function, but the input data needs to be a float64 confidence matrix right now =( I'll add something soon to allow float32 inputs (and will update this issue when done) - but in the meantime pass in a float64 matrix as a workaround. |
Ok, thanks, I am continuing to play with your great library and comparing results to the raw matrix factorization (with missed data points). Is the github is convenient/appropriate place to ask you about different results ? P.S. Also thank you for a insightful blog posts with visualisations 👍 |
Thanks for the feedback! Either GitHub or email works for contacting me - if you think that it might be of interest to other people, maybe just create another issue, otherwise my email address is on my github profile. I'll make sure to add the option to train on pre-initialized factors. I'm changing around a little bit anyways (moving to a class with methods for fitting the model, predicting for a user etc) - and I can easily put that in at the same time. |
The last commit allows training on pre-initialized factors: 8c18f16#diff-604d1b48a6ae71b2cc39b27249942f12R60. It will only initialize the factors if they haven't been set already. |
Thanks, |
This commit should enable this: #62 |
I was able to compile the package from source,
however I am getting error during the execution of the least_squares (cpp extension, python version is working)
Here is the corresponding line from _als.cpp
Can you please advise how to fix this ?
The text was updated successfully, but these errors were encountered: