Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Provide Clock.Until #29

Closed
rojer9-fb opened this issue Apr 7, 2021 · 4 comments · Fixed by #38
Closed

Provide Clock.Until #29

rojer9-fb opened this issue Apr 7, 2021 · 4 comments · Fixed by #38
Assignees

Comments

@rojer9-fb
Copy link

https://golang.org/pkg/time/#Until

@djmitche
Copy link
Collaborator

Would it be OK if I worked on this, @benbjohnson? Are PRs still accepted? :)

@djmitche
Copy link
Collaborator

Hm, tests are currently failing:

tereshkova ~/p/clock [master] $ go test -v .
=== RUN   TestClock_After
--- PASS: TestClock_After (0.02s)
=== RUN   TestClock_AfterFunc
panic: Fail in goroutine after TestClock_After has completed

goroutine 8 [running]:
testing.(*common).Fail(0xc0001321a0)
        /home/dustin/.gvm/gos/go1.17/src/testing/testing.go:710 +0xe5
testing.(*common).FailNow(0xc0001321a0)
        /home/dustin/.gvm/gos/go1.17/src/testing/testing.go:732 +0x1e
testing.(*common).Fatal(0x1c9c380, {0xc0000577c0, 0x0, 0x0})
        /home/dustin/.gvm/gos/go1.17/src/testing/testing.go:824 +0x4f
github.com/benbjohnson/clock.TestClock_After.func2()
        /home/dustin/p/clock/clock_test.go:21 +0x5e
created by github.com/benbjohnson/clock.TestClock_After
        /home/dustin/p/clock/clock_test.go:19 +0xb2
FAIL    github.com/benbjohnson/clock    0.034s
FAIL

@djmitche
Copy link
Collaborator

Ah, I think this is due to calling t.Fatal from a goroutine?

@djmitche
Copy link
Collaborator

#34 for the tests

@djmitche djmitche self-assigned this Oct 25, 2021
@djmitche djmitche mentioned this issue Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants