Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Feature Envy in Room.java to MXDataHandler.java #4

Open
bemica opened this issue Nov 29, 2018 · 1 comment
Open

Possible Feature Envy in Room.java to MXDataHandler.java #4

bemica opened this issue Nov 29, 2018 · 1 comment

Comments

@bemica
Copy link
Owner

bemica commented Nov 29, 2018

The method sendEvent in Room.java makes most of its calls to mDataHandler, an instance of MXDataHandler, suggesting that sendEvent, or some functionality thereof, might belong in MXDataHandler

Related to issue #3

@CourtneyJC
Copy link
Collaborator

sendEvent uses a lot of private fields in Room, so refactoring sendEvent to MXDataHandler would require exposing these fields, which is undesirable. On this basis we decided to leave the method where it is. Another potential fix would be to move the methods in MXDataHandler that sendEvent uses to Room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants