fix(stringify): should not throw error #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stringify method should return `undefined` if impossible to
stringify BEM notation.
It will be easier to check for an empty string than use `try..catch`.
**Before changes:**
```js
try {
var str = bemNaming.stringify({ elem: 'elem' });
} catch(e) { /* ... */ }
```
**After changes:**
```js
var str = bemNaming.stringify({ elem: 'elem' });
if (str) {
/* ... */
}
```
|
/cc @tadatuta |
| @@ -68,7 +68,7 @@ BEMNaming.prototype.typeOf = function (obj) { | |||
| obj = this.parse(obj); | |||
| } | |||
|
|
|||
| if (!obj || !obj.block) { return; } | |||
| if (!obj || !obj.block) { return undefined; } | |||
There was a problem hiding this comment.
isn't it just the same as before but with more letters? )
There was a problem hiding this comment.
yep, but it is more obviously
There was a problem hiding this comment.
well... I think previous variant was better but still lgtm :)
blond
added a commit
that referenced
this pull request
Mar 20, 2016
fix(stringify): should not throw error
qfox
added a commit
that referenced
this pull request
Jun 6, 2017
Update node-eval to version 1.0.4 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #55
The stringify method should return
undefinedif impossible tostringify BEM notation.
It will be easier to check for an empty string than use
try..catch.Before changes:
After changes: