🐛 Opening one expander opens all of them (intended?)

[mcquenji]

Describe the bug
Opening a single expander widget opens every other expander when changing route. Is this intended?

To Reproduce
Steps to reproduce the behavior:

1. Go to the fluent_ui example page
2. Open any expander
3. Change the route via sidebar
4. Watch all expanders open

Expected behavior
Expanders stay closed.

Screenshots

Additional context
The identifier for page storage seems to be at fault (if this is not intended) at fluent_ui/lib/src/controls/surfaces/expander.dart:180

PageStorage.of(context)?.writeState(
  context,
  open,
  identifier: 'expanderOpen', // Not unique to the specific expander widget
);

and fluent_ui/lib/src/controls/surfaces/expander.dart:143

_open = PageStorage.of(context)?.readState(
          context,
          identifier: 'expanderOpen', // Not unique to the specific expander widget
        ) as bool? ??
        widget.initiallyExpanded;

[mcquenji]

An option would be to use the key as identifier and don't store open state if none is provided.

Or do you want to store open state regardless of the key?

[ricard-v]

I can confirm this issue and I have arrived at the same conclusion. Is there a way to solve that while waiting a fix ?

[mcquenji]

I forked the repo, removed the page storage stuff, and used dependency_overrides section in pubspec.yaml.

As I've already done it, you can go ahead and use my fork:

dependency_overrides:
  fluent_ui:
    git:
      url: https://github.com/bmceachnie/fluent_ui.git

[ricard-v]

I forked the repo, removed the page storage stuff, and used dependency_overrides section in pubspec.yaml.

As I've already done it, you can go ahead and use my fork:

dependency_overrides:
  fluent_ui:
    git:
      url: https://github.com/bmceachnie/fluent_ui.git

Thanks for providing a fork and a way to use it (I did not know how to) 👍 .

I took a quick look at your code and as you said, you did remove the code related to writing & reading the opened state. That being said, I was wondering if there is still a way to use keys (something I am not knowledgeable about) or if PageStorage could still be used? Or perhaps both?

[mcquenji]

To my understanding, it'd be possible to use the key as an identifier instead of the hardcoded string expanderOpen.

If you need it, I could implement it.