Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Combobox animation is not correct #379

Closed
WinXaito opened this issue May 31, 2022 · 7 comments · Fixed by #454
Closed

🐛 Combobox animation is not correct #379

WinXaito opened this issue May 31, 2022 · 7 comments · Fixed by #454
Labels
bug Something isn't working

Comments

@WinXaito
Copy link
Collaborator

WinXaito commented May 31, 2022

Describe the bug

Dropdown has transparent effect and close is delayed, see the gif below:

fluent_dropdown

After update fluent_ui dep (currently on master).

(Windows 10)

@bdlukaa
Copy link
Owner

bdlukaa commented May 31, 2022

You mean ComboBox, right?

@WinXaito
Copy link
Collaborator Author

WinXaito commented May 31, 2022

Uhh, not sure, I need to check that. ComboBox/DropDown is a change since fluent_ui 3.8.0 ?

Edit: in fact, it certainly ComboBox, but I will check tomorrow

@WinXaito
Copy link
Collaborator Author

WinXaito commented Jun 1, 2022

Yup, that's a ComboBox:

My code (created when I had fluent_ui <2.8), so maybe I do not need DisableAcrylic:

SizedBox(
  width: 1000, // Max width, like W11 parameters style
  child: ListView(
    children: [
      ListTile(
        title: const Text('Thème (luminosité)'),
        subtitle: const Text(
            'Permet de définir le thème de l\'application (clair, sombre, système)'),
        trailing: SizedBox(
          width: 200,
//----
          child: DisableAcrylic(
            child: Combobox<ThemeMode>(
              value: model.themeMode,
              items: model.themeModeValues,
              onChanged: model.themeModeChanged,
            ),
          ),
//----
        ),
      ),
    ],
  ),
),

@WinXaito
Copy link
Collaborator Author

WinXaito commented Jun 1, 2022

Ok, after testing, removing DisableAcrylic fix the transparency problem, but ... I have Acrylic :( I don't want it.

And the freeze-problem is still present.

@bdlukaa
Copy link
Owner

bdlukaa commented Jun 1, 2022

Are you running it in debug mode? Can you try profile or release mode?

@WinXaito
Copy link
Collaborator Author

WinXaito commented Jun 1, 2022

I'm in debug mode, but that was work before.

I see the same effect on the web demo (and this is release mode..)

https://bdlukaa.github.io/fluent_ui/

-> Forms -> Color ComboBox
Or: InfoBar -> see the combobox

Edit: on demo:
fluent_combobox

it looks more like an animation synchronization problem than a freeze problem

@bdlukaa bdlukaa added the bug Something isn't working label Jun 1, 2022
@bdlukaa bdlukaa changed the title 🐛 Dropdown style and some freeze 🐛 Dropdown animation is not correct Jun 1, 2022
@WinXaito WinXaito changed the title 🐛 Dropdown animation is not correct 🐛 Combobox animation is not correct Jun 3, 2022
@DemoJameson
Copy link
Contributor

looks like it was introduce by this commit
7539087

@bdlukaa bdlukaa mentioned this issue Aug 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants