a couple minor tweaks to the command-specific completion logic in #185 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tschaub mind giving this branch a spin with your most up-to-date bash completion script? I think this solves my complaint about If things are looking good, we can cut a release candidate tomorrow |
|
@tschaub, cool I'll get a release out tonight. |
bcoe
added a commit
that referenced
this pull request
Jun 24, 2015
a couple minor tweaks to the command-specific completion logic in #185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a couple minor tweaks to the command-specific-completion logic in #185
we now always look for the
get-yargs-completionsoption, soyargs.completion()only needs to be called when registering a top-level command to generate a completion script.