From debbaa879079e0d8330ced0ad77ec7dc75389967 Mon Sep 17 00:00:00 2001
From: jonathan langlois <jonathan.langlois@gov.bc.ca>
Date: Wed, 22 Jan 2025 15:13:29 -0800
Subject: [PATCH] chore: remove insecure tls

remove skip tls step in github action
---
 .github/workflows/deploy-aggregator.yaml | 18 +++++++++---------
 .github/workflows/deploy-dashboard.yaml  |  1 -
 .github/workflows/deploy-promtail.yaml   |  1 -
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/deploy-aggregator.yaml b/.github/workflows/deploy-aggregator.yaml
index df0e617..bfed26a 100644
--- a/.github/workflows/deploy-aggregator.yaml
+++ b/.github/workflows/deploy-aggregator.yaml
@@ -53,7 +53,7 @@ jobs:
         labels: ${{ steps.meta.outputs.labels }}
 
     - name: Set env to Sandbox
-      if: (github.ref == 'refs/heads/ssoteam-1919' && github.event_name == 'push')
+      if: (github.ref == 'refs/heads/dev' && github.event_name == 'push')
       run: |
         cat >> $GITHUB_ENV <<EOF
         OPENSHIFT_TOKEN=${{ secrets.SANDBOX_OPENSHIFT_TOKEN }}
@@ -61,14 +61,14 @@ jobs:
         OPENSHIFT_NAMESPACE=e4ca1d-prod
         EOF
 
-    # - name: Set env to Production
-    #   if: (github.ref == 'refs/heads/main' && github.event_name == 'push')
-    #   run: |
-    #     cat >> $GITHUB_ENV <<EOF
-    #     OPENSHIFT_TOKEN=${{ secrets.PROD_OPENSHIFT_TOKEN }}
-    #     OPENSHIFT_SERVER=${{ secrets.PROD_OPENSHIFT_SERVER }}
-    #     OPENSHIFT_NAMESPACE=eb75ad-tools
-    #     EOF
+    - name: Set env to Production
+      if: (github.ref == 'refs/heads/main' && github.event_name == 'push')
+      run: |
+        cat >> $GITHUB_ENV <<EOF
+        OPENSHIFT_TOKEN=${{ secrets.PROD_OPENSHIFT_TOKEN }}
+        OPENSHIFT_SERVER=${{ secrets.PROD_OPENSHIFT_SERVER }}
+        OPENSHIFT_NAMESPACE=eb75ad-tools
+        EOF
 
     - name: Authenticate and set context
       uses: redhat-actions/oc-login@v1
diff --git a/.github/workflows/deploy-dashboard.yaml b/.github/workflows/deploy-dashboard.yaml
index a12aad0..4a8d606 100644
--- a/.github/workflows/deploy-dashboard.yaml
+++ b/.github/workflows/deploy-dashboard.yaml
@@ -48,7 +48,6 @@ jobs:
         openshift_server_url: ${{ env.OPENSHIFT_SERVER }}
         openshift_token: ${{ env.OPENSHIFT_TOKEN }}
         namespace: ${{ env.OPENSHIFT_NAMESPACE }}
-        insecure_skip_tls_verify: true
 
     - name: Deploy aggregator with Helm chart
       run: |
diff --git a/.github/workflows/deploy-promtail.yaml b/.github/workflows/deploy-promtail.yaml
index 399af52..70b2ef5 100644
--- a/.github/workflows/deploy-promtail.yaml
+++ b/.github/workflows/deploy-promtail.yaml
@@ -49,7 +49,6 @@ jobs:
         openshift_server_url: ${{ env.OPENSHIFT_SERVER }}
         openshift_token: ${{ env.OPENSHIFT_TOKEN }}
         namespace: ${{ env.OPENSHIFT_NAMESPACE }}
-        insecure_skip_tls_verify: true
 
     - name: Deploy aggregator-promtail with Helm chart
       run: |