Corp number with restorations

[Kaineatthelab]

Background

"For a NR that has been submitted for a restoration, for some reason, the incorp. number entered is being completely removed from the NR when we process it or make a change. I have two examples of this: 4468644 & 6375298"

The corp num is used by examiners for examination, it shows under the submit column.

Steps to reproduce

1. Client requests a name with the request type RESTORE (and must enter a corp num as part of this)
2. Examiner looks at the name, sees the corp num, edits it
3. Examiner saves changes
4. notice that the corp num is missing

Expected behavior

1. Client requests a name with the request type RESTORE (and must enter a corp num as part of this)
2. Examiner looks at the name, sees the corp num, edits it
3. Examiner saves changes
4. corp num is still included in the name request

screenshots

https://drive.google.com/file/d/1OGYLrCH9DThMYLAwllw_kA3m5tfVhm_3/view?usp=sharing
video of me replicating the bug

[Kaineatthelab]

@Sienna-Blumstengel @lmcclung @janisrogers can this be looked into and requirements need to be documented. Ideally for next sprint.

[sienna-oldaccountdontuse]

Verified this bug exists in TEST
https://drive.google.com/file/d/1OGYLrCH9DThMYLAwllw_kA3m5tfVhm_3/view?usp=sharing
Int he video, I request a name with corp num 0003463. Then i go into namex, edit the name, and the corp num has disappeared after i save.

I also tested what happens if a client edits their name request in any way. The corp num does NOT disappear.

Also, I tested what happens in name request after the corp num disappears. https://drive.google.com/file/d/1Aw8LDjJ8Sa4SMP-OoGI19kZkkU_R-cdL/view?usp=sharing

1. Edited name in NameX
2. corp num dissapeared
3. refreshed name request
4. edited nr from name request
5. saw that the corp num field was empty, i needed to enter something to submit the "edit my NR" form
6. I could add the corp num. Didn't try adding a new one, i added the original. it worked.
7. went back to namex and saw the corp num i entered when editing the nr in name request

[eve-git]

Need to review and update requestTypeRules.csv to see if the company number is a required field. The restoration related filing types:
RCR - B.C. Company - Restore
BERE - BC Benefit Company - Restore
RCC - CCC Restore
RCP - Corporation Restore
RFI - Financial Institution (BC) - Restore
RSO - Society Restore
RUL - ULC Restore

[eve-git]

Can not build and install correctly in both local and openshift. Looks like python version problem. node-sass is supported by python 2 but we have python 3.
The bug seems fixed. sass/node-sass#2877 I wonder if node-sass was updated in name-examination?

[eve-git]

The first step of the bug fix need to update requestTypeRules.csv and set Corp Num Required = TRUE for restoration requests.
Once Corp Num Required = TRUE, the corp number is editable and can be saved. May need to discuss with UI or business if corp number needs to be editable in the case.

Also, the most hard part is upgrading webpack, node-sass and dependences etc upon to the error message in build process.

The bug fix will be done after upgrade.

[eve-git]

DEV and TEST environments are ready to test.

Steps:

1. create an NR action = "Restore or Reinstate a..."
2. open name-examination, examine the name
3. click EDIT button. The corp number is available to be edited. Save Edits won't remove the corp number.

[oanyahuru]

Tested on both TEST and DEV, corp number shows and is editable.