You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem: Lrud assumes that there's always a parent node of the node we want to unregister. This is an incorrect assumption, preventing us from unregistering a root node.
@codan84 thanks for finding & raising an issue! We didn't look into unregistering without a parent, as we've not needed a reason to unregister the root node.
However, this is a valid use case, so will get a PR up and link it in here when complete.
To replicate:
Problem: Lrud assumes that there's always a parent node of the node we want to unregister. This is an incorrect assumption, preventing us from unregistering a root node.
Problematic line that throws an error: https://github.com/bbc/lrud/blob/master/src/index.ts#L222
The text was updated successfully, but these errors were encountered: