Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: compatibility with older Bazels #9

Closed
comius opened this issue Oct 10, 2024 · 3 comments · Fixed by #10
Closed

Feature request: compatibility with older Bazels #9

comius opened this issue Oct 10, 2024 · 3 comments · Fixed by #10
Assignees

Comments

@comius
Copy link
Collaborator

comius commented Oct 10, 2024

I have a problem.

  • ctx.expand_location has been allowlisted only in recent Bazel version
  • because rules_shell are now autoloaded protobuf needs to use them from github.com/bazelbuild/rules_shell
  • protobuf requires support from starting Bazel 6.

Probably the best solution would be to fallback to native shell rules on older Bazel versions.

@meteorcloudy
Copy link
Member

@fmeum Can you help with this one? This is required to make sure protobuf continues to work for older Bazel LTS versions.

@fmeum
Copy link
Collaborator

fmeum commented Oct 14, 2024

Sorry, I hadn't been watching this yet. I will try to add a version check.

@fmeum fmeum self-assigned this Oct 14, 2024
@comius
Copy link
Collaborator Author

comius commented Oct 14, 2024

If you trust me to remove the rules from Bazel 8, you can just wrap them in a macro and check if native has sh_library, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants