From 111b2a7eb3e538e6cb90abb63ad456fb069ca26f Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Fri, 24 May 2024 17:13:08 -0700 Subject: [PATCH] Loosen dash in proto path name check Fixes https://github.com/bazelbuild/rules_python/issues/1924 --- python/private/proto/py_proto_library.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/private/proto/py_proto_library.bzl b/python/private/proto/py_proto_library.bzl index e123ff8476..9f9ee53634 100644 --- a/python/private/proto/py_proto_library.bzl +++ b/python/private/proto/py_proto_library.bzl @@ -58,7 +58,7 @@ def _py_proto_aspect_impl(target, ctx): # Check Proto file names for proto in target[ProtoInfo].direct_sources: - if proto.is_source and "-" in proto.dirname: + if proto.is_source and "-" in proto.owner.package: fail("Cannot generate Python code for a .proto whose path contains '-' ({}).".format( proto.path, ))