Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py_test legacy_create_init should be False by default #221

Closed
shs96c opened this issue Aug 7, 2019 · 1 comment
Closed

py_test legacy_create_init should be False by default #221

shs96c opened this issue Aug 7, 2019 · 1 comment

Comments

@shs96c
Copy link
Contributor

shs96c commented Aug 7, 2019

Having the legacy_create_init attribute default to True is deeply confusing. Enabling legacy behaviour by default is a quirky thing to do, given that this seems to be an artefact of how Google use blaze. I believe that setting the default value to False will follow the principle of least surprise for most users.

@brandjon
Copy link
Member

brandjon commented Aug 7, 2019

Indeed, it's something we want to clean up by changing the default and then removing the flag entirely (under the principle that we should avoid global flags). Closing as dup of bazelbuild/bazel#7386.

@brandjon brandjon closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants