From eb53de2098ce5496f1fd2d1e511f39ecda7c4f06 Mon Sep 17 00:00:00 2001 From: brandjon Date: Fri, 31 May 2019 11:08:26 -0700 Subject: [PATCH] Enable Python toolchains by default (This is a roll-forward of https://github.com/bazelbuild/bazel/commit/bf66dc7210b46a13f86e144447f8d18505b79c2c.) This flips --incompatible_use_python_toolchains, which deprecates --python_top (and for the most part, --python_path). See #7899 for more on the change and migration procedure. Known downstream breakages are summarized [here](https://github.com/bazelbuild/bazel/issues/7899#issuecomment-497797353). Fixes #7899, fixes #7375, significant progress on #4815. RELNOTES[INC]: Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See [#7899](https://github.com/bazelbuild/bazel/issues/7899) for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses [#4815](https://github.com/bazelbuild/bazel/issues/4815) (incorrect interpreter version used) on non-Windows platforms. Note however that some builds break due to getting the version they asked for -- consider setting `python_version = "PY2"` on Python 2 targets and `--host_force_python=PY2` if any Python 2 targets are used in the host configuration. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. PiperOrigin-RevId: 250918912 --- .../google/devtools/build/lib/rules/python/PythonOptions.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java b/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java index ed298672827d23..ff06fdae3d7649 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java @@ -231,7 +231,7 @@ public String getTypeDescription() { @Option( name = "incompatible_use_python_toolchains", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.GENERIC_INPUTS, effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS}, metadataTags = {