Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to reuse the tsbuildinfo files on ts_project rule #2850

Closed
mistic opened this issue Aug 6, 2021 · 1 comment
Closed

Find a way to reuse the tsbuildinfo files on ts_project rule #2850

mistic opened this issue Aug 6, 2021 · 1 comment

Comments

@mistic
Copy link
Contributor

mistic commented Aug 6, 2021

Continues #1726

I had a quick conversation with @alexeagle and we think we need a way to make the typescript compilations at least so performant as they are with typescript outside bazel today without the express requirement of using a worker to achieve that.

I plan to start an experimentation with it and will update the issue accordingly.

@alexeagle
Copy link
Collaborator

@pauldraper is this still an area you're interested in? I heard you were working on an alternative implementation for Bazel/TS, did you make progress on that?

Since the .tsbuildinfo file is both an output from a compilation as well as an input to a subsequent one, we might still need a persistent worker under Bazel just to keep track of that file, as you pointed to in rules_scala https://github.com/higherkindness/rules_scala/blob/master/docs/stateful.md#stateful-compilation

This will lead to solving the same problem we have for existing workers: we currently need to setup the node_modules links when launching the nodejs process, but the needed third-party libraries differ for each WorkRequest.

We've been over this many times in the past, but since @mistic is interested in taking a deeper dive here maybe now is the time to revisit the discussions and look for more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants