From b4782b8eb064d07535b110d2cb7b3e2bc82f3599 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 13 Dec 2019 11:33:58 -0800 Subject: [PATCH] Remove local execution requirement for npm_package's create_package (#1443) * fix(builtin): remove local execution requirement for npm_package assembly action Removing the execution_requirement of local execution as this ends up being more costly when in a fully remote cachable tree of actions. * fix(builtin): add an indentifying mnemonic to create_package run action Adds a mnemonic to npm_package's create_package run action to allow it to be more easily/better identified. --- internal/npm_package/npm_package.bzl | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/internal/npm_package/npm_package.bzl b/internal/npm_package/npm_package.bzl index f3ba49d0d8..37d117610f 100644 --- a/internal/npm_package/npm_package.bzl +++ b/internal/npm_package/npm_package.bzl @@ -81,18 +81,11 @@ def create_package(ctx, deps_sources, nested_packages): ctx.actions.run( progress_message = "Assembling npm package %s" % package_dir.short_path, + mnemonic = "AssembleNpmPackage", executable = ctx.executable._packager, inputs = inputs, outputs = [package_dir, ctx.outputs.pack, ctx.outputs.publish], arguments = [args], - execution_requirements = { - # Never schedule this action remotely because it's not computationally expensive. - # It just copies files into a directory; it's not worth copying inputs and outputs to a remote worker. - # Also don't run it in a sandbox, because it resolves an absolute path to the bazel-out directory - # allowing the .pack and .publish runnables to work with no symlink_prefix - # See https://github.com/bazelbuild/rules_nodejs/issues/187 - "local": "1", - }, ) return package_dir