Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazelrc preset --nolegacy_external_runfiles for Bazel 8 #1016

Closed
hofbi opened this issue Dec 17, 2024 · 1 comment · Fixed by #1017
Closed

Update bazelrc preset --nolegacy_external_runfiles for Bazel 8 #1016

hofbi opened this issue Dec 17, 2024 · 1 comment · Fixed by #1017

Comments

@hofbi
Copy link
Contributor

hofbi commented Dec 17, 2024

The performance.bazelrc preset defines

build --nolegacy_external_runfiles
. In Bazel 8 --legacy_external_runfiles (bazelbuild/bazel#23574; now defaults to false).

Should we move the definition from performance.bazelrc into the Bazel 6 and Bazel 7 rc files? This would result in a small duplication.

@alexeagle
Copy link
Collaborator

Yes please, moving to bazel6 and bazel7 is the right solution. I don't think we want to create a bazel_6_or_7 file, the duplication is not worth the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants