Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inefficient count-min sketch table representation #60

Closed
racinmat opened this issue Jun 7, 2021 · 1 comment · Fixed by #93
Closed

Inefficient count-min sketch table representation #60

racinmat opened this issue Jun 7, 2021 · 1 comment · Fixed by #93

Comments

@racinmat
Copy link

racinmat commented Jun 7, 2021

Table representation for count-min sketch uses python list. Using numpy would be more efficient.
Should I make pull request with this?
@racinmat racinmat mentioned this issue Jun 7, 2021
Closed
@barrust
Copy link
Owner

barrust commented Jun 7, 2021

So, the basic philosophy so far has been to have a pure-python implementation of all the data so that there are no external dependencies to use the library. Can it be quantified how much performance gain would be achieved by adding numpy?

This was referenced Jan 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@barrust @racinmat