Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending deprecations #115

Closed
mathause opened this issue Dec 9, 2020 · 2 comments
Closed

pending deprecations #115

mathause opened this issue Dec 9, 2020 · 2 comments

Comments

@mathause
Copy link

mathause commented Dec 9, 2020

in xarray we get some deprecation warnings that stem from pseudonetcdf.

  • "rU" read mode:
 /usr/share/miniconda/envs/xarray-tests/lib/python3.8/site-packages/PseudoNetCDF/icarttfiles/ffi1001.py:95:
DeprecationWarning: 'U' mode is deprecated
    f = openf(path, 'rU', encoding=encoding)

there are several uses of "rU" those, e.g.:

ffifmt = openf(
path, 'rU', encoding='utf-8').readline().strip()[-4:]

The suggestion seems to be to just use "r" (https://stackoverflow.com/questions/56791545/what-is-the-non-deprecated-version-of-open-u-mode)

  • Time tuple will be replaced by datetime and dateutil
../../../../../usr/share/miniconda/envs/xarray-tests/lib/python3.8/site-packages/PseudoNetCDF/camxfiles/timetuple.py:18
  /usr/share/miniconda/envs/xarray-tests/lib/python3.8/site-packages/PseudoNetCDF/camxfiles/timetuple.py:18: PendingDeprecationWarning: Time tuple will be replaced by datetime and dateutil
    warn(PendingDeprecationWarning(

I don't think it's urgent, just wanted to mention it here. xref pydata/xarray#3266

@barronh
Copy link
Owner

barronh commented Dec 9, 2020

Thanks for the heads up! I'll fix these.

@barronh
Copy link
Owner

barronh commented Sep 21, 2021

The rU has been changed to r in PR #116. timetuple should still be addressed.

@barronh barronh closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants