Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-reporter): fix running web-reporter with absolute path #24

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Almouro
Copy link
Member

@Almouro Almouro commented Sep 13, 2022

Using process.cwd() was unnecessary, plus it was breaking absolute paths

For instance when running npx @perf-profiler/web-reporter /tmp/my-folder, the script would try to open /Users/almouro/dev/projects/my-project//tmp/my-folder instead of tmp/my-folder directly

@Almouro Almouro marked this pull request as ready for review September 13, 2022 12:05
@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

@Almouro Almouro merged commit f3d93ea into main Sep 13, 2022
@Almouro Almouro deleted the fix/web-reporter-command branch September 13, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants