Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not and greaterThan should work in case insensitive manner #4021

Closed
sailsbot opened this issue Mar 1, 2017 · 1 comment
Closed

not and greaterThan should work in case insensitive manner #4021

sailsbot opened this issue Mar 1, 2017 · 1 comment
Labels

Comments

@sailsbot
Copy link

sailsbot commented Mar 1, 2017

From @dmarcelino on April 30, 2015 10:41

In balderdashy/waterline-adapter-tests#53 I've added case insensitive not and greaterThan tests but unfortunately sails-mongo is breaking those tests: https://travis-ci.org/balderdashy/waterline-adapter-tests/jobs/60676152#L542

PR #235 looked like a potential fix but after trying it the tests still fail.

We need to fix this issue to put sails-mongo on par with the other adapters.

Perhaps http://stackoverflow.com/questions/1863399/mongodb-is-it-possible-to-make-a-case-insensitive-query can help us get here...

cc: @andypham, @particlebanana, @tjwebb, @devinivy, @andyhu, @mgenev

Copied from original issue: balderdashy/sails-mongo#265

@particlebanana
Copy link
Contributor

Solved and now mongo is case-sensitive in Waterline 0.13 so wrapping this one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants