Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sails.sockets.join failed #6454

Closed
Biktop opened this issue Feb 8, 2016 · 1 comment
Closed

sails.sockets.join failed #6454

Biktop opened this issue Feb 8, 2016 · 1 comment

Comments

@Biktop
Copy link

Biktop commented Feb 8, 2016

I called sails.sockets.join and got
ReferenceError: id is not defined

I've discovered that code socket = app.io.sockets.connected[id]; refers to unknown variable id

I think that here socket should be used.
@sgress454
Copy link
Member

Great catch @Biktop, patched and published 0.13.7. Thanks!

@johnabrams7 johnabrams7 transferred this issue from balderdashy/sails-hook-sockets May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgress454 @Biktop