Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic Registry should store the precise schema type #78

Closed
raminqaf opened this issue Sep 18, 2022 · 1 comment
Closed

Topic Registry should store the precise schema type #78

raminqaf opened this issue Sep 18, 2022 · 1 comment
Labels
component/manager type/bug Something isn't working

Comments

@raminqaf
Copy link
Contributor

Issue description

Curenntly, the Internal Topic Registry, does not contain the precise schema type of the topic. Concretely, if Quick is configured with one of the supported schemas (i.e., Avro or Protobuf), the Internal Topic Registry registers each topic only with the value type SCHEMA.

Expected Behavior

That the Internal Topic Registry stores the correct schema type in the value type of a topic.

Current Behavior

The Internal Topic Registry registers the value type of a topic with a schema as SCHEMA.
Here is a screenshot of a registered topic with schema:
Screenshot 2022-09-18 at 13 27 20

Steps to Reproduce

  1. Create a topic with a schema: quick topic create example-topic --key-type int --value-type schema --schema test-gateway.mytype
  2. Use Redpanda Console to see the registered topic

Detailed Description

The TopicController class sets the value type to SCHEMA. The TopicService does not check if the schema type is Avro or Protobuf.

@raminqaf raminqaf added type/bug Something isn't working component/manager labels Sep 18, 2022
@raminqaf raminqaf added this to Quick Sep 18, 2022
@raminqaf raminqaf moved this to Todo in Quick Oct 4, 2022
@raminqaf raminqaf moved this from Todo to Done in Quick Nov 30, 2022
@raminqaf raminqaf moved this from Done to Todo in Quick Nov 30, 2022
@raminqaf raminqaf closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2022
Repository owner moved this from Todo to Done in Quick Nov 30, 2022
@raminqaf
Copy link
Contributor Author

Closing this issue because now we are using the quick-config as a reference for the schema configuration. This can be reopened if we want to support multiple schema types in one quick release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/manager type/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant