Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small docs fix: defs --> prestart #9887

Merged
merged 1 commit into from
Jan 13, 2024
Merged

small docs fix: defs --> prestart #9887

merged 1 commit into from
Jan 13, 2024

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jan 9, 2024

running npm run defs omits the BASE_URL= env var

@chris48s
small docs fix: defs --> prestart
e6c1bba 
running `npm run defs` omits the BASE_URL= env var
@chris48s chris48s added the documentation Developer and end-user documentation label Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against e6c1bba

jNullj
jNullj approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chris48s chris48s added this pull request to the merge queue Jan 13, 2024
Merged via the queue into badges:master with commit 7e8b85e Jan 13, 2024
22 checks passed
@chris48s chris48s deleted the docs-defs branch January 13, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

@jNullj jNullj jNullj approved these changes

Assignees
No one assigned
Labels
documentation Developer and end-user documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris48s @PyvesB @jNullj