Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Bower data using libraries.io #919

Merged
merged 1 commit into from
Sep 17, 2017
Merged

Fetch Bower data using libraries.io #919

merged 1 commit into from
Sep 17, 2017

Conversation

paulmelnikow
Copy link
Member

A standard API key with https://libraries.io/ covers 60 requests per minute. Will that be enough for the public server?

Do you see any reason not to use let, const, template strings, and arrow functions in new code?

@paulmelnikow paulmelnikow added the performance-improvement Related to performance or throughput of the badge servers label Mar 29, 2017
@paulmelnikow paulmelnikow requested a review from espadrine March 29, 2017 23:36
- Avoid downloading bower packages via git
- Service is well resourced: https://libraries.io/team
- Same service used by https://bower.io/search/
@espadrine
Copy link
Member

Do you see any reason not to use let, const, template strings, and arrow functions in new code?

No. Let's do that from now on.

Will that be enough for the public server?

Hang on, I'll try to gather that info.

@paulmelnikow paulmelnikow added service-badge New or updated service badge operations Hosting, monitoring, and reliability for the production badge servers labels Apr 17, 2017
@espadrine
Copy link
Member

espadrine commented Sep 4, 2017

We get less than 1k req/h, so less than 20 req/min. The shoe fits.

@espadrine espadrine merged commit 852784b into badges:master Sep 17, 2017
@paulmelnikow paulmelnikow deleted the better_bower branch September 22, 2017 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operations Hosting, monitoring, and reliability for the production badge servers performance-improvement Related to performance or throughput of the badge servers service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants