From 7753098646275fea5882903d4740526e8f2f726e Mon Sep 17 00:00:00 2001 From: Ahmad Nassri Date: Fri, 3 Apr 2015 14:57:46 -0400 Subject: [PATCH 1/4] Github Releases Download counter possible combinations: - `/github/downloads/:user/:repo/latest/total.svg` - `/github/downloads/:user/:repo/:release_id/total.svg` - `/github/downloads/:user/:repo/:release_id/:asset_name.svg` --- server.js | 44 ++++++++++++++++++++++++++++++++++++++++++++ try.html | 4 ++++ 2 files changed, 48 insertions(+) diff --git a/server.js b/server.js index 08cda1217ed6f..001b78c42fd35 100644 --- a/server.js +++ b/server.js @@ -1966,6 +1966,50 @@ cache(function(data, match, sendBadge, request) { }); })); +// GitHub release-download-count integration. +camp.route(/^\/github\/downloads\/([^\/]+)\/([^\/]+)\/([^\/]+)\/([^\/]+)\.(svg|png|gif|jpg|json)$/, +cache(function(data, match, sendBadge, request) { + var user = match[1]; // eg, qubyte/rubidium + var repo = match[2]; + var id = match[3]; + var asset_name = match[4].toLowerCase(); + var format = match[5]; + var apiUrl = 'https://api.github.com/repos/' + user + '/' + repo + '/releases/' + id; + // Using our OAuth App secret grants us 5000 req/hour + // instead of the standard 60 req/hour. + if (serverSecrets) { + apiUrl += '?client_id=' + serverSecrets.gh_client_id + + '&client_secret=' + serverSecrets.gh_client_secret; + } + var badgeData = getBadgeData('downloads', data); + // A special User-Agent is required: + // http://developer.github.com/v3/#user-agent-required + request(apiUrl, { headers: githubHeaders }, function(err, res, buffer) { + if (err != null) { + badgeData.text[1] = 'inaccessible'; + sendBadge(format, badgeData); + } + try { + if ((+res.headers['x-ratelimit-remaining']) === 0) { + return; // Hope for the best in the cache. + } + var data = JSON.parse(buffer); + var downloads = 0; + data.assets.map(function (asset) { + if (asset_name === 'total' || asset_name === asset.name.toLowerCase()) { + downloads += asset.download_count + } + }); + badgeData.text[1] = metric(downloads) + (asset_name? ' ' + asset_name: ' total'); + badgeData.colorscheme = 'brightgreen'; + sendBadge(format, badgeData); + } catch(e) { + badgeData.text[1] = 'none'; + sendBadge(format, badgeData); + } + }); +})); + // GitHub issues integration. camp.route(/^\/github\/issues(-raw)?\/([^\/]+)\/([^\/]+)\.(svg|png|gif|jpg|json)$/, cache(function(data, match, sendBadge, request) { diff --git a/try.html b/try.html index 605866bbc71ac..4472935b95163 100644 --- a/try.html +++ b/try.html @@ -167,6 +167,10 @@

Build

Downloads

+ + + + From 478fc27003b96884ec09e6a366097dd89fdbfd5c Mon Sep 17 00:00:00 2001 From: Ahmad Nassri Date: Thu, 9 Apr 2015 19:33:05 -0400 Subject: [PATCH 2/4] code review updates --- server.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server.js b/server.js index 001b78c42fd35..4818493d28eeb 100644 --- a/server.js +++ b/server.js @@ -1972,7 +1972,7 @@ cache(function(data, match, sendBadge, request) { var user = match[1]; // eg, qubyte/rubidium var repo = match[2]; var id = match[3]; - var asset_name = match[4].toLowerCase(); + var asset_name = match[4].toLowerCase(); // eg. total, atom-amd64.deb, atom.x86_64.rpm var format = match[5]; var apiUrl = 'https://api.github.com/repos/' + user + '/' + repo + '/releases/' + id; // Using our OAuth App secret grants us 5000 req/hour @@ -1987,7 +1987,7 @@ cache(function(data, match, sendBadge, request) { request(apiUrl, { headers: githubHeaders }, function(err, res, buffer) { if (err != null) { badgeData.text[1] = 'inaccessible'; - sendBadge(format, badgeData); + return sendBadge(format, badgeData); } try { if ((+res.headers['x-ratelimit-remaining']) === 0) { @@ -1995,9 +1995,9 @@ cache(function(data, match, sendBadge, request) { } var data = JSON.parse(buffer); var downloads = 0; - data.assets.map(function (asset) { + data.assets.forEach(function (asset) { if (asset_name === 'total' || asset_name === asset.name.toLowerCase()) { - downloads += asset.download_count + downloads += asset.download_count; } }); badgeData.text[1] = metric(downloads) + (asset_name? ' ' + asset_name: ' total'); From 8d8a88a3fff3efd6d156bf0f66f4ccace8c8f81d Mon Sep 17 00:00:00 2001 From: Ahmad Nassri Date: Mon, 13 Apr 2015 11:48:52 -0400 Subject: [PATCH 3/4] improvements + grab releases by tag name instead of obscure ID + more examples + better labels --- index.html | 12 ++++++++++++ server.js | 11 ++++++++--- try.html | 10 +++++++++- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/index.html b/index.html index d1550e70d537b..2286a66406ecf 100644 --- a/index.html +++ b/index.html @@ -168,6 +168,18 @@

Build

Github: https://img.shields.io/github/downloads/atom/atom/latest/total.svg
npm: https://img.shields.io/npm/dm/localeval.svg

Downloads

+ + + + + + + + + + + + diff --git a/server.js b/server.js index 4818493d28eeb..3258a0cc1be1e 100644 --- a/server.js +++ b/server.js @@ -1971,10 +1971,11 @@ camp.route(/^\/github\/downloads\/([^\/]+)\/([^\/]+)\/([^\/]+)\/([^\/]+)\.(svg|p cache(function(data, match, sendBadge, request) { var user = match[1]; // eg, qubyte/rubidium var repo = match[2]; - var id = match[3]; + var tag = match[3]; var asset_name = match[4].toLowerCase(); // eg. total, atom-amd64.deb, atom.x86_64.rpm var format = match[5]; - var apiUrl = 'https://api.github.com/repos/' + user + '/' + repo + '/releases/' + id; + var release_path = tag !== 'latest' ? 'tags/' + match[3] : 'latest'; + var apiUrl = 'https://api.github.com/repos/' + user + '/' + repo + '/releases/' + release_path; // Using our OAuth App secret grants us 5000 req/hour // instead of the standard 60 req/hour. if (serverSecrets) { @@ -2000,7 +2001,11 @@ cache(function(data, match, sendBadge, request) { downloads += asset.download_count; } }); - badgeData.text[1] = metric(downloads) + (asset_name? ' ' + asset_name: ' total'); + var label = tag === 'latest' ? 'latest version' : tag; + if (asset_name !== 'total') { + label += ' ' + '[' + asset_name + ']'; + } + badgeData.text[1] = metric(downloads) + ' ' + label; badgeData.colorscheme = 'brightgreen'; sendBadge(format, badgeData); } catch(e) { diff --git a/try.html b/try.html index 4472935b95163..4886d2b180b40 100644 --- a/try.html +++ b/try.html @@ -167,10 +167,18 @@

Build

Github Releases: https://img.shields.io/github/downloads/atom/atom/latest/total.svg
Github Releases (by Release): https://img.shields.io/github/downloads/atom/atom/v0.190.0/total.svg
Github Releases (by Asset): https://img.shields.io/github/downloads/atom/atom/latest/atom-amd64.deb.svg
npm: https://img.shields.io/npm/dm/localeval.svg

Downloads

- + + + + + + + + + From 5cdfeb51e1fcd62f200849e80762ab7b444467ad Mon Sep 17 00:00:00 2001 From: Ahmad Nassri Date: Sat, 18 Apr 2015 13:02:30 -0400 Subject: [PATCH 4/4] silent if latest --- server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server.js b/server.js index f93777f8fc014..20b9da423a22a 100644 --- a/server.js +++ b/server.js @@ -2086,7 +2086,7 @@ cache(function(data, match, sendBadge, request) { downloads += asset.download_count; } }); - var label = tag === 'latest' ? 'latest version' : tag; + var label = tag !== 'latest' ? tag : ''; if (asset_name !== 'total') { label += ' ' + '[' + asset_name + ']'; }
Github:
Github Releases: https://img.shields.io/github/downloads/atom/atom/latest/total.svg
Github Releases (by Release): https://img.shields.io/github/downloads/atom/atom/v0.190.0/total.svg
Github Releases (by Asset): https://img.shields.io/github/downloads/atom/atom/latest/atom-amd64.deb.svg
npm: https://img.shields.io/npm/dm/localeval.svg