Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitrise] Added new build service Bitrise.io #1227

Merged
merged 3 commits into from
Oct 31, 2017

Conversation

freezy-sk
Copy link
Contributor

Added new service Bitrise.io requested in #574

@paulmelnikow paulmelnikow changed the title Added new build service Bitrise.io [bitrise] Added new build service Bitrise.io Oct 30, 2017
@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Oct 30, 2017
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this!

const t = new ServiceTester({ id: 'bitrise', title: 'Bitrise' });
module.exports = t;

t.create('deploy status')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the branch is optional, could you add a second test which omits it?

@paulmelnikow
Copy link
Member

Thanks! Good to merge when tests are passing. It looks like there is a syntax error in Node 6.

@freezy-sk
Copy link
Contributor Author

@paulmelnikow sorry I forgot commas :)

@paulmelnikow paulmelnikow merged commit ad4a8b4 into badges:master Oct 31, 2017
@paulmelnikow
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants