Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The second (numeric) half of badge crawls up as text #454

Closed
Tourorist opened this issue May 28, 2015 · 8 comments
Closed

The second (numeric) half of badge crawls up as text #454

Tourorist opened this issue May 28, 2015 · 8 comments

Comments

@Tourorist
Copy link
Contributor

Hello,
Please see acemod/ACE3/pull/1410 (View). This wasn't the case until recently. Am I correct to assume that labeling has become more strict (letter-case) as of late, or am I simply doing something wrong there?

@Tourorist
Copy link
Contributor Author

To clarify, the badges in question are generic and are updated by hand with no templates behind them.

@Tourorist
Copy link
Contributor Author

@espadrine, don't hit me too hard if this is in fact a repost of the #445 issue. 😛🔨

@espadrine
Copy link
Member

I see an uppercase V here: http://img.shields.io/badge/Version-3.0.1-blue.svg?style=flat

@espadrine
Copy link
Member

Ah, sorry. Yes, Heroku is really slow now.

@Tourorist
Copy link
Contributor Author

I'ill just wait for this to resolve on its own then. Thank you! 🙇

@Tourorist
Copy link
Contributor Author

BTW, @espadrine, though it works in the URL, do you mean that ?label= query is a more preferable way to handle letter casing?

@espadrine
Copy link
Member

When using /badge/, as far as I know, label is only necessary in complex cases where - escaping does not work. I even made label not necessary when the left-hand side text is empty. If it has an impact on letter casing, it's a bug.

@Tourorist
Copy link
Contributor Author

I see; will keep that in mind.

Never mind the text links acting up, apparently I am an idiot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants