Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields.io shows that my site is turned off. However, it is not. #2812

Closed
dorokhin opened this issue Jan 19, 2019 · 19 comments
Closed

Shields.io shows that my site is turned off. However, it is not. #2812

dorokhin opened this issue Jan 19, 2019 · 19 comments
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge

Comments

@dorokhin
Copy link

dorokhin commented Jan 19, 2019

Are you experiencing an issue with...

🪲 Description

Shilds.io shows that my site is turned off. However, it is not.
This happened after I updated the certificates, and the SSL settings of the web server

www.ssllabs.com shows that my server has an A + rating

🔗

https://img.shields.io/website-up-down-green-red/https/dorokhin.moscow.svg?label=dorokhin.moscow

ssllabs report

** Screenshots **
Screenshot 1
Screenshot 1

💡 Possible Solution

Update your ssl client library.

@calebcartwright calebcartwright added the service-badge New or updated service badge label Jan 19, 2019
@chris48s chris48s added the bug Bugs in badges and the frontend label Jan 19, 2019
@chris48s
Copy link
Member

Tried this locally and its throwing:

{
Error: write EPROTO 139639970006848:error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3
alert handshake failure:../deps/openssl/openssl/ssl/s23_clnt.c:802: at
WriteWrap.afterWrite [as oncomplete] (net.js:868:14) errno: 'EPROTO', code: 'EPROTO', syscall: 'write'
}

Can make a HEAD request OK with curl:

$ curl -I --head "https://dorokhin.moscow/"
HTTP/1.1 200 OK

@paulmelnikow
Copy link
Member

I can't reproduce that locally in Node 10, though I can in Node 9 and Node 8. I don't have access to upgrade Node on the servers, but it seems like that's what we'll need to do.

@paulmelnikow
Copy link
Member

We could also try setting secureProtocol to the Node 10 value to see if it fixes this. There's some differences in the docs in Node 9 and the subsequent versions.

@chris48s
Copy link
Member

Suspect its probably this then: nodejs/node#3692 Might be some settings we can fiddle with if you trawl that thread, but node 10 has a more recent version of openssl which fixes this.

@chris48s chris48s changed the title Shilds.io shows that my site is turned off. However, it is not. Shields.io shows that my site is turned off. However, it is not. Jan 19, 2019
@paulmelnikow
Copy link
Member

The ssl test report shows a handful of client failures:

This is from their documentation:

In order to support older clients, you may need to continue to support TLS v1.0 and TLS v1.1 for now. However, you should plan to retire TLS v1.0 in the near future. For example, the PCI DSS standard will require all sites that accept credit card payments to remove support for TLS v1.0 by June 2018.

screen shot 2019-01-20 at 8 56 35 am

screen shot 2019-01-20 at 8 56 45 am

Sort of tangential: it would be cool to have a TLS version support badge.

@paulmelnikow
Copy link
Member

By adding this service test, I confirmed that TLS 1.2 is not the issue with dorokhin.moscow.

t.create('status of a TLS 1.2 site')
  .only()
  .get('/website/https/tls-v1-2.badssl.com:1012.json')
  .expectJSON({ name: 'website', value: 'online' })

That passes in Node 8 and 9.

@paulmelnikow
Copy link
Member

So… it's failing for some other reason. I'm guessing it's related to the ciphers.

@mfominov
Copy link

mfominov commented Sep 2, 2019

or u can add
require("tls").DEFAULT_ECDH_CURVE = "auto"
to server.js

@derSoerrn95
Copy link

@dorokhin: how did u solve your problem?

@mfominov
Copy link

@dorokhin: how did u solve your problem?

try my comment with server.js

@derSoerrn95
Copy link

it works with self-hosted version. but the shield.io version always shows down.

@paulmelnikow
Copy link
Member

The production servers are now running Node 10.20.1 so this should be resolved.

Can anyone confirm?

@paulmelnikow
Copy link
Member

I can't confirm this is fixed but I'm going to close it. If this isn't fixed, feel free to comment here and we'll reopen.

@derSoerrn95
Copy link

nice, it works for my page now :)

@dorokhin
Copy link
Author

dorokhin commented May 1, 2020

I can't confirm this is fixed but I'm going to close it. If this isn't fixed, feel free to comment here and we'll reopen.

it works!

@paulmelnikow

This comment has been minimized.

@badges badges locked as resolved and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Development

No branches or pull requests

7 participants
@paulmelnikow @chris48s @derSoerrn95 @mfominov @dorokhin @calebcartwright and others