Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all logos from simple-icons will work? #2223

Closed
Sopor opened this issue Oct 28, 2018 · 3 comments · Fixed by #2231
Closed

Not all logos from simple-icons will work? #2223

Sopor opened this issue Oct 28, 2018 · 3 comments · Fixed by #2231

Comments

@Sopor
Copy link

Sopor commented Oct 28, 2018

It is possible to use logos from different projects and even from simple-icons. I have tested a lot of them on simple-icons and they work, but not Lua and that is the icon i want to use. I noticed that SparkFun is not working either.
Shouldn't all of them work?

@RedSparr0w
Copy link
Member

RedSparr0w commented Oct 28, 2018

Thanks for reporting this 👍

It looks like any icons added after v1.9.7 are not showing on shields badges.
Which is strange as we should currently be using the latest simple-icons version (v1.9.9) in production:

Edit:
It looks like none of the logos added after v1.7.1 are working.
Testing locally all the badges work on the latest version.

@paulmelnikow Do you think maybe the npm packages haven't been updating during deploys?

@paulmelnikow
Copy link
Member

It runs npm install every time, though it doesn’t respect package-lock. This is frustrating, of course, because locking deps in production is the whole point of using package-lock on an application.

Is simple-icons bumped in package.json?

@paulmelnikow
Copy link
Member

Ref: #1988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants