Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace missing in footer #1334

Closed
tooomm opened this issue Dec 5, 2017 · 4 comments
Closed

whitespace missing in footer #1334

tooomm opened this issue Dec 5, 2017 · 4 comments
Labels
frontend The Docusaurus app serving the docs site

Comments

@tooomm
Copy link
Contributor

tooomm commented Dec 5, 2017

Same as #1318 needs to be applied to the footer at the very bottom:

footer

@paulmelnikow paulmelnikow added the frontend The Docusaurus app serving the docs site label Dec 5, 2017
@RedSparr0w
Copy link
Member

RedSparr0w commented Dec 5, 2017

Also as a side note in regards to the spacing,
The social style badge has extra white space at the end which needs to be fixed,
the svg element is 5px 4px wider than it needs to be.
image
image
That's why it looks like there is some spacing between those and the other badges.

@tooomm
Copy link
Contributor Author

tooomm commented Dec 6, 2017

Thanks for fixing the pixel issue already in #1337 @RedSparr0w

Now, the initial issue can be spotted better:
footer

@paulmelnikow
Copy link
Member

paulmelnikow commented Dec 6, 2017

It's a matter of adding { } after elements that need spaces, as in #1318. (Added: That's a space followed by { }. It's clearer in the diff than in this comment.)

If you want to give it a shot, @RedSparr0w or I can ship a review app which will let you test it through the browser.

@RedSparr0w
Copy link
Member

No worries, ill give it a go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The Docusaurus app serving the docs site
Projects
None yet
Development

No branches or pull requests

3 participants