Respect babel sourceMaps option #158
Conversation
index.js
Outdated
|
|
||
| let options = { | ||
| annotation: providedAnnotation || `Babel: ${this._parentName()}` | ||
| annotation: addonOptions.annotation || `Babel: ${this._parentName()}`, | ||
| sourceMaps: addonOptions.sourceMaps || babelOptions.sourceMaps |
There was a problem hiding this comment.
Hmm, I'm not sure that we should do this sort of fallback. Each option needs to have a single place to live, if we have to support both locations one should be deprecated.
There was a problem hiding this comment.
I thought babel was deprecated. At least, I remember fixing a deprecation error when I upgraded to ember-cli 2.12
There was a problem hiding this comment.
Both are still valid, but each of them for different types of options.
At this point, I would say that sourceMaps should go in babel config (since we do pass it through directly to babel itself), and that we shouldn't allow it to be specified in options['ember-cli-babel'].
There was a problem hiding this comment.
Sounds good. I won't bother with a warning or deprecation message since sourceMaps was never valid inside ember-cli-babel to begin with
|
can someone point me to instructions on how to use this? |
The
babel.sourceMapsoption stopped working since the switch to ember-cli-babel. The option is used to enable ES6 sources in the debugger.This PR enables sourceMaps under the
ember-cli-babel.sourceMapsconfig option and alsobabel.sourceMapsfor backwards compatibility.Originally implemented in ember-cli/ember-cli#6458
Fixes (again) ember-cli/ember-cli#6066