Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

debug option: using plugins/using polyfills should account for includes/excludes #127

Closed
hzoo opened this issue Jan 9, 2017 · 3 comments
Labels

Comments

@hzoo
Copy link
Member

hzoo commented Jan 9, 2017

ref #109 (not due to this pr but related)

@yavorsky realized the logging is kinda broken for exclude/include. pluginList and builtIns list should be printed after accounting for include/exclude. Not sure if we want to remove it from the list or do something like a different color or (removed)

aside: Sometimes its also useful to show the plugins/built-ins that were not used too.
something like https://cloud.githubusercontent.com/assets/3918488/20965291/4c6a753c-bc75-11e6-9b6d-853f0952b647.png could be cool

@yavorsky
Copy link
Member

yavorsky commented Jan 9, 2017

I've just changed log format for this part. It was broken after include/exclude implementation because it logs plugins (not built-ins) before considering include/exclude: https://github.com/babel/babel-preset-env/blob/master/src/index.js#L277

@yavorsky
Copy link
Member

yavorsky commented Jan 9, 2017

I can create a PR with hotfix during 20 minutes.

@hzoo
Copy link
Member Author

hzoo commented Jan 9, 2017

Since its just the debug log it's not a big deal but 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants