-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh time is too slow in expo react-native project after upgrade #983
Comments
@nicolo-ribaudo please help with this as you made changes for 8.3.0 |
Can you provide a repo to reproduce it? |
@liuxingbaoyu thanks for the response. Here is a repro project: https://drive.google.com/file/d/1lYluHiGl4UVnp9bbPjcIOid09NnbYifX/view?usp=sharing It takes 30 seconds for a simple text change to apply. With babel-loader 8.2.5 or below, takes 2-3 seconds max. |
@elitenas Thanks. I have downloaded the repro and will take a look. |
@elitenas Can you attach the specific reproduction steps? Here is mine:
The page reload is instant, less than 3 seconds consistently. |
@JLHwung My repro steps were similar.
The only thing i would point out is make sure you are on npm > 8.3.x. I am not in front of my my work laptop but I believe we are on 8.19.2. Otherwise the overrides object in package.json is ignored if you are on npm below that. Let me know if this doesn't work. I had another developer reproduce this well. So i can double check. Expo by default doesn't use babel-loader 8.3.0 yet |
Yes I am aware of that. I also tried bumping |
It takes about 10s for my test, and I will downgrade the loader for testing. By the way, it is recommended to update webpack, because repro does not work by default in the new version of node. |
Just tried on a brand new laptop and it takes around 10 seconds. Keep in mind this is a barebone project. In our main project its taking 45 seconds. |
@liuxingbaoyu @elitenas Okay, maybe this issue is platform dependent. I am on arm64. |
I can confirm the problem.
Yeah, it's possible. I use windows, I will try to fix it. |
Changes brought by #971. |
Haven't tested yet but this seems about right. I wasn't able to reproduce the slowness in babel-loader 9.1.2 after upgrading to expo 48 |
@liuxingbaoyu any update on this for 8.x.x? |
I'm submitting a bug report
Webpack Version:
1.10.x/2.x
Babel Core Version:
7.20.12
Babel Loader Version:
8.3.0
Please tell us about your environment:
OSX 10.x / Linux / Windows 10: OSX 13.2
Current behavior: Watch refresh time is too slow after upgrading from 8.2.5 to 8.30 in react-native expo project
Expected/desired behavior: Once i make an edit on a file, the refresh should be within 5 seconds but it takes 45 secs
The text was updated successfully, but these errors were encountered: