Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using deps-info for neil new implementation #116

Closed
rads opened this issue Aug 27, 2022 · 9 comments
Closed

Consider using deps-info for neil new implementation #116

rads opened this issue Aug 27, 2022 · 9 comments

Comments

@rads
Copy link
Collaborator

rads commented Aug 27, 2022

I needed to use the same tools.deps inference for bbin so I moved the code to a shared library:

https://github.com/rads/deps-infer

I suggest we add a dependency for this lib in neil and update the neil new implementation to use this.

I plan to maintain deps-infer going forward since it's a useful library on its own without bbin or neil.

bb --config <(echo "{:deps $(deps-infer --lib io.github.rads/watch)}") \
  -e "(require 'rads.watch) (rads.watch/print-help nil)"
@borkdude
Copy link
Contributor

@rads Hmm, I already have a library with the same name but with a different purpose: https://github.com/borkdude/deps-infer.

@rads
Copy link
Collaborator Author

rads commented Aug 27, 2022

@borkdude: Ah, I didn't know about that one! I can change the name if that's the main blocker here.

@rads rads closed this as completed Aug 27, 2022
@rads
Copy link
Collaborator Author

rads commented Aug 27, 2022

Woops, wrong button!

@rads rads reopened this Aug 27, 2022
@rads
Copy link
Collaborator Author

rads commented Aug 27, 2022

I should clarify that I plan to change the name regardless of whether we use the library for neil. Definitely want to avoid any conflicts with your library.

@borkdude
Copy link
Contributor

On the other hand, borkdude/deps-infer isn't very actively developed and used, so maybe it's not a big deal. Coming up with a good unique name is hard.

@borkdude
Copy link
Contributor

Other than that, I don't see a problem, other than maybe some redundant code in the library which could slow down neil's startup time. I do prefer keeping neil's deps as lean as possible to ensure good startup and bb compatibility.

@rads
Copy link
Collaborator Author

rads commented Aug 27, 2022

@borkdude:

I do prefer keeping neil's deps as lean as possible to ensure good startup and bb compatibility.

I agree. I think I can keep any extra stuff out of neil by splitting the namespaces and using :deps/root as needed.

@rads rads changed the title Consider using deps-infer for neil new implementation Consider using deps-info for neil new implementation Sep 6, 2022
@rads
Copy link
Collaborator Author

rads commented Sep 15, 2022

I've created a duplicate issue of #79 in rads/deps-info#1. This means I can implement the GitLab/Bitbucket/Beanstalk/Sourcehut integration there and both bbin and neil will be able to use it.

Going to hold off on using deps-info for neil until rads/deps-info#1 is done first.

@rads
Copy link
Collaborator Author

rads commented Apr 26, 2024

I'm moving the deps-info code inline into bbin so I'm going to close this issue for now.

@rads rads closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants