Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new nREPL lookup op #27

Closed
borkdude opened this issue Aug 13, 2020 · 6 comments
Closed

Implement new nREPL lookup op #27

borkdude opened this issue Aug 13, 2020 · 6 comments

Comments

@borkdude
Copy link
Contributor

No description provided.

@kolharsam
Copy link
Contributor

Hey @borkdude, could you provide more context on this?

@borkdude
Copy link
Contributor Author

@kolharsam Hi! I don't know a lot about this, but this was a request that came from the nREPL project. Possibly @bozhidar knows more.

I found some docs here: https://nrepl.org/nrepl/ops.html#lookup

In general it's best if you look at example messages sent back and forth using this:

https://docs.cider.mx/cider/troubleshooting.html#debugging-the-communication-with-nrepl

and then try to implement that.

@kolharsam
Copy link
Contributor

kolharsam commented Dec 15, 2020

@bbatsov could you please provide some context on this?

@bbatsov
Copy link

bbatsov commented Dec 15, 2020

It's the op editors are supposed by default to resolve a symbol to a var and procure its definition location metadata (amongst others) https://nrepl.org/nrepl/ops.html#lookup

I think everything you need is here nrepl/nrepl@6291c2e

@borkdude
Copy link
Contributor Author

@bbatsov We don't need more context on the operation, that's pretty clear. But there is one open question here about something CIDER-specific:

#33 (comment)

@borkdude
Copy link
Contributor Author

I believe this is now implemented in 0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants