Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 1 if any file is fixed #52

Closed
josejulio opened this issue Dec 11, 2018 · 1 comment
Closed

Return 1 if any file is fixed #52

josejulio opened this issue Dec 11, 2018 · 1 comment

Comments

@josejulio
Copy link

In my precommit workflow, i would like to fail the commit if any file has to be fixed.

  "precommit": "yarn pretty-quick --no-restage"

Currently if there is any file is fixed, it will commit, but i want to abort the current commit.
josejulio added a commit to josejulio/pretty-quick that referenced this issue Dec 12, 2018
@josejulio
feat: Fail on fix (prettier#52)
4f0a9b9
josejulio added a commit to josejulio/pretty-quick that referenced this issue Dec 12, 2018
@josejulio
feat: Fail on fix (prettier#52)
78a715d
josejulio added a commit to josejulio/pretty-quick that referenced this issue Dec 13, 2018
@josejulio
feat: Fail on fix (prettier#52)
0383a5e
jantimon pushed a commit to jantimon/pretty-quick that referenced this issue Jan 17, 2019
@josejulio @jantimon
feat: Add --bail option which fails on fix (prettier#52)
143faed
jantimon pushed a commit to jantimon/pretty-quick that referenced this issue Jan 17, 2019
@josejulio @jantimon
feat: Add --bail option which fails on fix (prettier#52)
0799764
jantimon pushed a commit to jantimon/pretty-quick that referenced this issue Jan 17, 2019
@josejulio @jantimon
feat: Add --bail option which fails on fix (prettier#52)
f57dfb3
azz pushed a commit that referenced this issue Jan 17, 2019
@jantimon @azz
feat: add --bail option which fails on fix (#52) (#60)
054e239
@azz azz closed this as completed Jan 17, 2019
@jorgeorpinel
Copy link

Hi! So --bail is just --no-restage but exiting with 1? So I should never need to use both options at the same time? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azz @jorgeorpinel @josejulio