DB/Creature using temporary auras in c_addon.auras

[Kitzunu]

Current Behaviour

Auras with duration should not be used in c_a/c_t_a.auras, they should be cast using a script.

creature_template_addon https://gist.github.com/Kitzunu/ec2300f5eeee239228b245d0aa3909c3
creature_addon https://gist.github.com/Kitzunu/b86990492e8a459d3ddcf2de62b6b5c2

See Steps to reproduce the problem to get an accurate up-to-date list of the creatures

Expected Behaviour

Clean up by removing the entries in c_a/c_t_a and adding the aura through script. Some creatures might have the wrong aura in the auras and some creatures already cast it through script (like entry 3739) but still have it in c_a/c_t_a.

Source

No response

Steps to reproduce the problem

Swap out LOG_DEBUG to LOG_ERROR to get a correct updated list in your own console

diff --git a/src/server/game/Globals/ObjectMgr.cpp b/src/server/game/Globals/ObjectMgr.cpp
index dede1dbed1..15706ae5fd 100644
--- a/src/server/game/Globals/ObjectMgr.cpp
+++ b/src/server/game/Globals/ObjectMgr.cpp
@@ -909,8 +909,8 @@ void ObjectMgr::LoadCreatureTemplateAddons()
 
             if (spellInfo->GetDuration() > 0)
             {
-                LOG_DEBUG/*ERROR*/("sql.sql", "Creature (Entry: {}) has temporary aura (spell {}) in `auras` field in `creature_template_addon`.", entry, spellInfo->Id);
-                // continue;
+                LOG_ERROR("sql.sql", "Creature (Entry: {}) has temporary aura (spell {}) in `auras` field in `creature_template_addon`.", entry, spellInfo->Id);
+                continue;
             }
 
             creatureAddon.auras.push_back(spellInfo->Id);
@@ -1335,8 +1335,8 @@ void ObjectMgr::LoadCreatureAddons()
 
             if (spellInfo->GetDuration() > 0)
             {
-                LOG_DEBUG/*ERROR*/("sql.sql", "Creature (Entry: {}) has temporary aura (spell {}) in `auras` field in `creature_template_addon`.", guid, spellInfo->Id);
-                // continue;
+                LOG_ERROR("sql.sql", "Creature (GUID: {}) has temporary aura (spell {}) in `auras` field in `creature_addon`.", guid, spellInfo->Id);
+                continue;
             }
 
             creatureAddon.auras.push_back(spellInfo->Id);

Extra Notes

When all of them are resolved the debug message on load should be swapped to LOG_ERROR

AC rev. hash/commit

826b55d

Operating system

W11

Custom changes or Modules

No response