Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP-34 support & ArtZero marketplace integration #6

Closed
vacekj opened this issue Nov 25, 2022 · 1 comment · Fixed by #79
Closed

PSP-34 support & ArtZero marketplace integration #6

vacekj opened this issue Nov 25, 2022 · 1 comment · Fixed by #79
Assignees
@realnimish
Labels
effort: medium

Comments

@vacekj
Copy link

vacekj commented Nov 25, 2022 •
edited by wottpal
Loading

No description provided.

@vacekj vacekj mentioned this issue Nov 25, 2022
Closed
@vacekj vacekj self-assigned this Nov 25, 2022
@vacekj vacekj added this to the Launch milestone Nov 25, 2022
@wottpal wottpal removed this from the Launch milestone Dec 1, 2022
@wottpal
Copy link
Member

wottpal commented Jan 16, 2023 •
edited
Loading

ArtZero sample PSP-34 implementation: https://github.com/ArtZero-io/psp34_nft_contract
OpenBrush PSP-34: https://docs.openbrush.io/smart-contracts/PSP34/

  • Only owner can do transfers
  • Everything should be cleared by default for transfers (metadata, mappings). But when using our frontend, it should be possible to keep metadata/controller/resolving address via 3 optional booleans (see design).
  • When doing NFT transfers, everything should be cleared by default
  • NFTs should also be implicitly "burned" when domain is expired/released
  • TBD: How the actual NFT metadata json looks

@vacekj vacekj assigned vacekj and unassigned vacekj Feb 18, 2023
@realnimish realnimish mentioned this issue Mar 15, 2023
Merged
@realnimish realnimish mentioned this issue Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realnimish realnimish

Labels
effort: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement PSP34 standard azero-id/contracts
3 participants
@wottpal @vacekj @realnimish