Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Report : Please merge this critical pointer dereference fix to ensure cross-architecture compatibility. #730

Closed
ouni666 opened this issue Mar 19, 2025 · 2 comments · Fixed by #732
Assignees

Comments

@ouni666
Copy link

ouni666 commented Mar 19, 2025

Issue

Issue Report

File Path: src/core/core.cpp
Line: 475

Error Description:
Original problematic code:

std::make_shared<ARM_DynCom>(this, *memory, USER32MODE, i, timing->GetTimer(i)));

Modified code:
std::make_shared<ARM_DynCom>(*this, *memory, USER32MODE, i, timing->GetTimer(i)));

The missing * before this causes build failures on non-x86 architectures.

Verification:

Successfully tested on LA664 microarchitecture (3a6000 processor)
Confirmed AMD platform compilation passed
Request:
Please merge this critical pointer dereference fix to ensure cross-architecture compatibility.

Image

Image

@ouni666
Copy link
Author

ouni666 commented Mar 19, 2025

Just to add, I am using a Loongson 3A6000 processor based on the LoongArch64 instruction set architecture.

The 3A6000 processor is not based on the RISC-V architecture. Instead, it features a more advanced instruction set that originated from RISC (Reduced Instruction Set Computer).

@PabloMK7
Copy link
Member

Confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants