Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeptuneStack failed to create #320

Closed
s4kharitonov opened this issue Nov 17, 2022 · 6 comments
Closed

NeptuneStack failed to create #320

s4kharitonov opened this issue Nov 17, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@s4kharitonov
Copy link

s4kharitonov commented Nov 17, 2022

If your issue relates to the Discovery Process, please first follow the steps described in the implementation guide Debugging the Discovery Component


Describe the bug
Creation of WDNeptuneDBCluster failed

The Parameter Group workload-discovery-neptune-cluster-parameter-group with DBParameterGroupFamily neptune1 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily neptune1.2 (Service: AmazonNeptune; Status Code: 400; Error Code: InvalidParameterCombination; Request ID: 43e211aa-5f07-40a6-af07-4ffc2d3b6f87; Proxy: null)

To Reproduce
Steps to reproduce the behavior:

Run main.template

Expected behavior
NeptuneStack created successful

Screenshots

img-2022-11-17-16-33-06

img-2022-11-17-16-25-11

@s4kharitonov s4kharitonov added the bug Something isn't working label Nov 17, 2022
@svozza
Copy link
Contributor

svozza commented Nov 17, 2022

@dieherna
Copy link

dieherna commented Nov 21, 2022

Svozza I have been trying to figure out exactly how to implement the provided workaround however I am not having much luck. When you import the Cloudformation template I don’t see an option to be able to edit the nested neptune.template. I have also tried uploading the contents of the cfn folder from this github to my own S3 bucket and then tried deploying the main.template after modifying neptune.template but then the stack fails to build as it looks like it doesn’t resolve the variables in main.template. Also I notice there are some zip files that some of the other templates are referencing.

Any guidance you can provide is much appreciated.

@svozza
Copy link
Contributor

svozza commented Nov 22, 2022

The easiest way to get it working is the do a local build. Clone the repo, make the changes to the template and follow the instructions here: https://github.com/awslabs/workload-discovery-on-aws#deploying-a-local-build.

@s4kharitonov
Copy link
Author

Local build

Failed on TaskStack stack

  TaskStack:
    Type: AWS::CloudFormation::Stack
    Properties:
      TemplateURL:
        !Sub
          - ${DeploymentBucket}/discovery-crawler.template
          - DeploymentBucket: !GetAtt Variables.DeploymentBucket
      TimeoutInMinutes: 60
      Parameters:
        DiscoveryBucket: !GetAtt S3Buckets.Outputs.DiscoveryBucket
        AppName: !FindInMap [Solution, Constants, AppName]
        PrivateSubnet0: !GetAtt VpcStack.Outputs.PrivateSubnet0
        PrivateSubnet1: !GetAtt VpcStack.Outputs.PrivateSubnet1
        VpcId: !GetAtt VpcStack.Outputs.VPCId
        VpcEndpointsSg: !GetAtt VpcStack.Outputs.VpcEndpointsSg
        ImageVersion: !FindInMap [Solution, Constants, ImageVersion]
        ConfigurationAggregator: !GetAtt ConfigAggregator.Outputs.PerspectiveConfigurationAggregator
        AppSyncArn: !GetAtt AppSyncApiStack.Outputs.AppSyncApiArn
        AppSyncApiUrl: !GetAtt AppSyncApiStack.Outputs.AppSyncApiUrl
        Cpu: 1024
        Memory: 2048
        Decorators: !GetAtt LayerStack.Outputs.Decorators
        BotoUtils: !GetAtt LayerStack.Outputs.BotoUtils
        CustomResourceHelper: !GetAtt LayerStack.Outputs.CustomResourceHelper
        DeploymentBucketName: !GetAtt Variables.DeploymentBucketName
        DeploymentBucketKey: !FindInMap [ Solution, Constants, DeploymentBucketKey ]

Template: discovery-crawler.template

  CleanupECRRepository:
    Type: Custom::Setup
    Properties:
      ServiceToken: !GetAtt CleanupRepositoryFunction.Arn
      LogLevel: !Ref LogLevel
      Repository: !Ref PerspectiveContainerRepo

img-2022-11-23-13-56-01

@svozza
Copy link
Contributor

svozza commented Nov 23, 2022

This issue has arisen before but I've never been able to reproduce it for some reason. To unblock yourself, just comment out that custom resource in the cfn template and reupload it. All it means is that if you uninstall, you'll have to manually delete the ECR repository.

@svozza
Copy link
Contributor

svozza commented Nov 23, 2022

The fix for the Neptune issue has now been released. You can download the updated template here: https://aws.amazon.com/solutions/implementations/workload-discovery-on-aws/.

@svozza svozza closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants