Reduce allocations and garbage #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Dec 6, 2021
smithy-model/src/main/java/software/amazon/smithy/model/validation/ValidationUtils.java
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/model/validation/validators/PrivateAccessValidator.java
Show resolved
Hide resolved
...l/src/main/java/software/amazon/smithy/model/validation/validators/TraitTargetValidator.java
Outdated
Show resolved
Hide resolved
This commit attempts to cut down on the amount of allocations used when validating Smithy models, including limiting the use of Streams in core APIs, no longer copying validation events passed to ValidatedResult, and no longer caching the result of every selector used in trait defintions when evaluating trait targets.
mtdowling
force-pushed
the
reduce-garbage
branch
from
51da933 to
145e854
Compare
kstich
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to cut down on the amount of allocations used when
validating Smithy models, including limiting the use of Streams in core
APIs, no longer copying validation events passed to ValidatedResult, and
no longer caching the result of every selector used in trait defintions
when evaluating trait targets.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.