Add SSDK codegen test #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
test-generated-ssdk
branch
2 times, most recently
from
c4f2d0b to
7e28c12
Compare
srchase
commented
Jul 12, 2023
| @@ -0,0 +1,32 @@ | |||
| extra["displayName"] = "Smithy :: Typescript :: SSDK :: Codegen :: Test :: Utils" | |||
| extra["moduleName"] = "software.amazon.smithy.typescript.ssdk.codegen.test.utils" | |||
There was a problem hiding this comment.
This adds the TestProtocolGenerator as a separate package. With work on the build-script, this could get added to the existing smithy-typescript-codegen-test package, but I think it makes more sense to keep that implementation separated into its own package. Implementations like protocol generators should generally end up in their own package for re-use outside of a single service model.
hpmellema
approved these changes
Jul 12, 2023
| dependencies { | ||
| implementation(project(":smithy-typescript-codegen")) | ||
| implementation("software.amazon.smithy:smithy-model:$smithyVersion") | ||
| } |
srchase
force-pushed
the
test-generated-ssdk
branch
from
7e28c12 to
fbd7b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing of the
typescript-ssdk-codegenplugin.It adds the non-published
software.amazon.smithy.typescript.ssdk.codegen.test.utilspackage, which includes an emptyFakeProtocolGeneratorwhich enables SSDK codegen to succeed since a protocol is required for an SSDK.Currently, SSDK validation for
@streamingunion shapes is not supported, so theGetCityAnnouncementsis removed from the generated SSDK since it uses the@streamingunionAnnouncementsshape in its output. Once support for this is added, the operation can be added back to the model.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.